Sruhvx-jpg commented on code in PR #3288: URL: https://github.com/apache/iceberg-rust/pull/3288#discussion_r4152934498
########## crates/storage/common/src/lib.rs: ########## @@ -0,0 +1,21 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Shared storage test suite for Apache Iceberg. Review Comment: This is intended as a single central test matrix for all storage implementations, following the precedent from #2131 for catalogs. OpenDAL is currently the only merged storage crate under crates/storage/ in main, but the TODO in StorageKind is already in place and I will personally follow up to wire up the object_store backend as soon as #3165 merges. Perhaps I should have stacked this PR directly on top of #3165 instead, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
