Sruhvx-jpg commented on PR #3288: URL: https://github.com/apache/iceberg-rust/pull/3288#issuecomment-5927613554
Pushed a commit addressing the review feedback. For the items raised: - split the unreachable skip path from setup/readiness failures (with readiness timeout and GCS bucket creation failure now failing hard with backend context), and gated skips behind `ICEBERG_REQUIRE_STORAGE=1`; - restored the dropped serialization roundtrips for both GCS in `file_io_suite` and resolving storage in `resolving_suite`; - loosened the out-of-bounds range-read assertion to accept empty reads alongside errors, adding a `TODO` comment to tighten it once the `FileRead` spec is standardized; - left a reply on the inline thread regarding the shared suite architecture and #3165 stacking — there is an explicit `TODO` in place to wire up the `object_store` S3 backend once #3165 merges, which I will follow up and implement myself. The rest — switching `.unwrap()` to `?` in the helpers, `TempDir` and delete-on-exit for hermetic resolving paths, moving probe tests to a dedicated `tests/endpoint_probe.rs` without the DNS query, asserting `ErrorKind::Unexpected` (as noted inline), dropping the no-op builder tests from `credential_suite`, and the `Cargo.toml` dependency cleanup — are all resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
