fmorillo7694 commented on code in PR #17901:
URL: https://github.com/apache/iceberg/pull/17901#discussion_r4154182994
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergCommitter.java:
##########
@@ -324,6 +349,49 @@ private void commitOperation(
}
}
+ private static class MaxCommittedCheckpointMismatchException extends
ValidationException {
Review Comment:
Done. I extracted `MaxCommittedCheckpointIdValidator` (and its mismatch
exception) into a shared `@Internal` class in `org.apache.iceberg.flink.sink`.
Both `IcebergCommitter` and `DynamicCommitter` now use it, and the duplicate in
`DynamicCommitter` is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
