kevinjqliu commented on code in PR #18349:
URL: https://github.com/apache/iceberg/pull/18349#discussion_r4167987495
##########
site/nav.yml:
##########
@@ -98,7 +97,9 @@ nav:
- Starrocks:
https://docs.starrocks.io/en-us/latest/data_source/catalog/iceberg_catalog
- Tinybird:
https://www.tinybird.co/docs/forward/get-data-in/table-functions/iceberg
- Trino: https://trino.io/docs/current/connector/iceberg.html
- - Releases: releases.md
+ - Releases:
Review Comment:
this way we're not "releasing" spec changes (right now its under
"releases"), its simply a changelog
##########
site/nav.yml:
##########
@@ -98,7 +97,9 @@ nav:
- Starrocks:
https://docs.starrocks.io/en-us/latest/data_source/catalog/iceberg_catalog
- Tinybird:
https://www.tinybird.co/docs/forward/get-data-in/table-functions/iceberg
- Trino: https://trino.io/docs/current/connector/iceberg.html
- - Releases: releases.md
+ - Releases:
Review Comment:
do you think it'll be better to move the specification change log to
https://iceberg.apache.org/terms/ subtab?
Below "Implementation status" perhaps?
<img width="957" height="476" alt="Image"
src="https://github.com/user-attachments/assets/24bb368a-3b7c-43b9-abcb-ebb8ec13fdfa";
/>
##########
format/RELEASES.md:
##########
@@ -0,0 +1,150 @@
+---
+title: "Specification Releases"
+---
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Specification Releases
+
+Specifications are adopted by community vote and take effect when the vote
+passes. They are not tied to the release of any implementation, so
specification
+changes are tracked here rather than in the release notes of the Java or any
+other implementation.
+
+This page records changes to the specifications under the `format` directory.
+Changes to the REST catalog specification are not covered here.
Review Comment:
we should probably find a places for the REST spec change too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
