rdblue commented on code in PR #17343:
URL: https://github.com/apache/iceberg/pull/17343#discussion_r4169889288
##########
core/src/main/java/org/apache/iceberg/expressions/ExpressionParser.java:
##########
@@ -178,24 +215,26 @@ public <T> Void predicate(UnboundPredicate<T> pred) {
return generate(
() -> {
gen.writeStartObject();
-
gen.writeStringField(TYPE, operationType(pred.op()));
- gen.writeFieldName(TERM);
- term(pred.term());
- if (pred.literals() != null) {
- if (pred.op() == Expression.Operation.IN
- || pred.op() == Expression.Operation.NOT_IN) {
- gen.writeArrayFieldStart(VALUES);
+ if (pred.op() == Expression.Operation.IN || pred.op() ==
Expression.Operation.NOT_IN) {
Review Comment:
What is the rationale for changing the structure? I think it would still
work just fine, just with the term/child/left added at the same time. That
would be a smaller change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
