rdblue commented on code in PR #17343:
URL: https://github.com/apache/iceberg/pull/17343#discussion_r4169911025
##########
core/src/main/java/org/apache/iceberg/expressions/ExpressionParser.java:
##########
@@ -50,6 +59,30 @@ public class ExpressionParser {
private static final String CHILD = "child";
private static final String REFERENCE = "reference";
private static final String LITERAL = "literal";
+ private static final String LITERALS = "literals";
+ private static final String DATA_TYPE = "data-type";
+ private static final String APPLY = "apply";
+ private static final String FUNCTION = "function";
+ private static final String ARGUMENTS = "arguments";
+ private static final String NAME = "name";
+ private static final String ID = "id";
+ private static final String IDENTIFIER = "identifier";
+ private static final String CATALOG = "catalog";
+
+ private static final Pattern HAS_WIDTH = Pattern.compile("(\\w+)\\[(\\d+)]");
+
+ private static final String ICEBERG_FUNCTIONS = "iceberg_functions";
+ // the expressions spec defines partition transforms as functions, other
than void
Review Comment:
This is true, but they must be in the `iceberg_functions` catalog. And I
don't think that we need to return the `Transform` from the parser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
