stevenzwu commented on code in PR #16936: URL: https://github.com/apache/iceberg/pull/16936#discussion_r4170363705
########## core/src/main/java/org/apache/iceberg/MapBackedContentStats.java: ########## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.nio.ByteBuffer; +import java.util.Map; +import java.util.Objects; +import java.util.Set; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.Iterables; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.types.Conversions; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.Types; + +/** Reusable {@link ContentStats} view over a {@link ContentFile}'s stat maps. */ +class MapBackedContentStats implements ContentStats { + private final Schema tableSchema; + private final MetricsConfig metricsConfig; + private final Types.StructType type; + private final Map<Integer, FieldStats<?>> statsById = Maps.newHashMap(); + + private Map<Integer, Long> valueCounts; + private Map<Integer, Long> nullValueCounts; + private Map<Integer, Long> nanValueCounts; + private Map<Integer, Integer> avgValueSizes; + private Map<Integer, ByteBuffer> lowerBounds; + private Map<Integer, ByteBuffer> upperBounds; + + MapBackedContentStats(Schema tableSchema, MetricsConfig metricsConfig) { + Preconditions.checkArgument(tableSchema != null, "Invalid table schema: null"); + Preconditions.checkArgument(metricsConfig != null, "Invalid metrics config: null"); + this.tableSchema = tableSchema; + this.metricsConfig = metricsConfig; + this.type = StatsUtil.statsWriteSchema(tableSchema, metricsConfig); Review Comment: I was trying to implement option 2. In the latest commit, I fixed the bug that you pointed out. Option 1 build the content stats once for each wrap call from the table schema and the union set of field ids from maps. Option 2 built the content stats once from the table schema and MetricsConfig. Building once (option 2) is 3.6–5.4× faster than rebuilding on every wrap (option 1). Throughput is ops/ms, JDK 21, higher is better. | Columns | Rebuilt each wrap | Built once | Speedup | | ---: | ---: | ---: | ---: | | 2 | 2284 | 9527 | 4.17× | | 10 | 559 | 2009 | 3.59× | | 50 | 83 | 445 | 5.36× | | 200 | 18 | 69 | 3.83× | The wrapper is eventually used in the write path. Using MetricsConfig seems fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
