pvary commented on code in PR #17900:
URL: https://github.com/apache/iceberg/pull/17900#discussion_r4184663542
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/EvolveSchemaVisitor.java:
##########
@@ -210,6 +215,14 @@ private void addColumn(int parentId, Types.NestedField
field) {
private void updateColumn(Types.NestedField existingField, Types.NestedField
targetField) {
String existingColumnName =
this.existingSchema.findColumnName(existingField.fieldId());
+ // A column cannot be promoted to variant; fail instead of silently
skipping the update
+ Preconditions.checkArgument(
Review Comment:
Maybe in a follow-up we can check this immediately in
`TableUpdater.findOrCreateSchema`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
