rdblue commented on a change in pull request #2021:
URL: https://github.com/apache/iceberg/pull/2021#discussion_r560579299
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/utils/RewriteRowLevelOperationHelper.scala
##########
@@ -67,8 +83,17 @@ trait RewriteRowLevelOperationHelper extends PredicateHelper
with Logging {
scan match {
case filterable: SupportsFileFilter =>
- val matchingFilePlan = buildFileFilterPlan(scanRelation.output,
matchingRowsPlanBuilder(scanRelation))
- DynamicFileFilter(scanRelation, matchingFilePlan, filterable)
+ if (performCountCheckForMerge) {
+ val affectedFilesAcc = new SetAccumulator[String]()
+ spark.sparkContext.register(affectedFilesAcc,
AFFECTED_FILES_ACC_NAME)
Review comment:
What if this accumulator has already been used? Will you get the results
from the previous accumulator if you run two MERGE INTO statements on the same
table?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
