stevenzwu commented on a change in pull request #2109:
URL: https://github.com/apache/iceberg/pull/2109#discussion_r560643694
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java
##########
@@ -305,6 +334,14 @@ public void processElement(StreamRecord<WriteResult>
element) {
this.writeResultsOfCurrentCkpt.add(element.getValue());
}
+ @Override
+ public void processWatermark(Watermark mark) throws Exception {
+ super.processWatermark(mark);
+ if (mark.getTimestamp() != Watermark.MAX_WATERMARK.getTimestamp()) {
Review comment:
why do we need to ignore the `MAX_WATERMARK`? it signals the end of
input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
