stevenzwu commented on pull request #2109: URL: https://github.com/apache/iceberg/pull/2109#issuecomment-763329566
@dixingxing0 yeah. extending the `FlinkSink.Builder` sounds like a right approach to me. Small suggestion on the naming: - storeWatermarkEnabled -> storeWatermark - flink.watermark-for-default -> flink.watermark.default ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
