singhpk234 commented on code in PR #18081:
URL: https://github.com/apache/iceberg/pull/18081#discussion_r4213061381
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1276,6 +1307,27 @@ private FileIO tableFileIO(
return newFileIO(context, fullConf.buildKeepingLast(), storageCredentials);
}
+ private boolean useClientSideStorageAccessForEncryptedTable(TableMetadata
tableMetadata) {
+ return useClientSideStorageAccessForEncryptedTables()
+ && tableMetadata != null
+ &&
tableMetadata.properties().containsKey(TableProperties.ENCRYPTION_TABLE_KEY);
+ }
+
+ private void validateNoServerSideStorageAccess(
Review Comment:
can you please elaborate this a bit more ? whats the concerns with failing
the catalog intialization if the client is set to ask for vended creds ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
