singhpk234 commented on code in PR #18081:
URL: https://github.com/apache/iceberg/pull/18081#discussion_r4266644084
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -276,6 +287,12 @@ public void initialize(String name, Map<String, String>
unresolved) {
RESTCatalogProperties.METRICS_REPORTING_ENABLED,
RESTCatalogProperties.METRICS_REPORTING_ENABLED_DEFAULT);
+ if (props.containsKey(CatalogProperties.ENCRYPTION_KMS_TYPE)
+ || props.containsKey(CatalogProperties.ENCRYPTION_KMS_IMPL)) {
+ this.keyManagementClient = EncryptionUtil.createKmsClient(props);
Review Comment:
How does this
https://github.com/apache/iceberg/pull/18081/commits/c0a86f02b06a9f6a7a1068c18f5bc87df76fe8c0
sounds ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
