marton-bod opened a new pull request #2123: URL: https://github.com/apache/iceberg/pull/2123
As agreed with the community: - Iceberg table properties are the canonical source of truth - HMS table properties should be maintained as much as possible to be in sync with the Iceberg table, but it can only happen on a best effort basis This PR makes the following changes: - Ensures that all Iceberg table properties are propagated to the HMS table during `HiveTableOperations` commit - All HMS table properties are pushed down to Iceberg as well during table creation (except for metadata location and spec props) - Refactors the various property check assertions scattered throughout various test cases into a single property-focused unit test case What is left out and should be done in the future: - Push property changes occurring via Hive DDL (`ALTER TABLE SET TBLPROPERTIES`) down to Iceberg as well. Currently this can't be done reliably because the `HiveMetaHook` interface only contains a `preAlterTable` method, but no `commitAlterTable` method. We'll need to extend this interface and include the change in an upcoming Hive upstream release. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
