marton-bod commented on a change in pull request #2123:
URL: https://github.com/apache/iceberg/pull/2123#discussion_r561783557
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -191,6 +193,10 @@ public void reset() throws Exception {
}
}
+ public Table getTable(String dbName, String tableName) throws TException,
InterruptedException {
Review comment:
I think so. Keeping the method gives us future flexibility to run custom
metastore client methods without touching the TestHiveMetastore interface, but
at the same time, it feels like we're breaching the TestMetastore abstraction
by exposing its client pool directly, so it's better to introduce new methods
like getTable whenever it becomes necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
