dramaticlly commented on code in PR #18406:
URL: https://github.com/apache/iceberg/pull/18406#discussion_r4224067860
##########
docs/docs/spark-configuration.md:
##########
@@ -206,6 +206,7 @@ val spark = SparkSession.builder()
| spark.sql.iceberg.executor-cache.max-entry-size | 67108864 (64MB)
| Max size per cache entry (bytes)
|
| spark.sql.iceberg.executor-cache.max-total-size | 134217728 (128MB)
| Max total executor cache size
(bytes)
|
| spark.sql.iceberg.executor-cache.locality.enabled | false
| Enables locality-aware executor
cache usage
|
+| spark.sql.iceberg.snapshot-property._custom-key_ | null
| Adds an entry with custom-key and
corresponding value to the summary of snapshots committed by writes and by the
`rewrite_data_files`, `rewrite_position_delete_files`, and `rewrite_manifests`
procedures. Write options and properties set on an action take precedence |
Review Comment:
noticed there's later section which also populate the custom metadata to a
snapshot summary during a SQL execution `CommitMetadata.withCommitProperties`,
but list to per SQL writes. I think this complements with spark rewrite
actions, might consider move later to it sits together? Some example on how
explicit override session conf can also be helpful IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
