anuragmantri commented on code in PR #18406:
URL: https://github.com/apache/iceberg/pull/18406#discussion_r4273118051
##########
docs/docs/spark-configuration.md:
##########
@@ -206,6 +206,7 @@ val spark = SparkSession.builder()
| spark.sql.iceberg.executor-cache.max-entry-size | 67108864 (64MB)
| Max size per cache entry (bytes)
|
| spark.sql.iceberg.executor-cache.max-total-size | 134217728 (128MB)
| Max total executor cache size
(bytes)
|
| spark.sql.iceberg.executor-cache.locality.enabled | false
| Enables locality-aware executor
cache usage
|
+| spark.sql.iceberg.snapshot-property._custom-key_ | null
| Adds an entry with custom-key and
corresponding value to the summary of snapshots committed by writes and by the
`rewrite_data_files`, `rewrite_position_delete_files`, and `rewrite_manifests`
procedures. Write options and properties set on an action take precedence |
Review Comment:
This property isn't new in this PR. #14545 added it for regular writes
(`SparkWrite` and `SparkPositionDeltaWrite` apply it through
`SparkWriteConf.extraSnapshotMetadata()`), but that PR didn't add the property
to the docs. This PR expands the scope of that property to maintenance actions.
The documentation reflects what it applies to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]