lcspinter commented on a change in pull request #2126:
URL: https://github.com/apache/iceberg/pull/2126#discussion_r561106918
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimeObjectInspector.java
##########
@@ -49,8 +50,11 @@ public Text getPrimitiveWritableObject(Object o) {
}
@Override
- public Object convert(Object o) {
- return o == null ? null : o.toString();
+ public LocalTime convert(Object o) {
+ if (o == null) {
+ return null;
+ }
+ return LocalTime.parse(o.toString());
Review comment:
Fixed.
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -88,9 +91,10 @@
private static final List<Type> SUPPORTED_TYPES =
ImmutableList.of(Types.BooleanType.get(), Types.IntegerType.get(),
Types.LongType.get(),
- Types.FloatType.get(), Types.DoubleType.get(),
Types.DateType.get(), Types.TimestampType.withZone(),
+ Types.FloatType.get(), Types.DoubleType.get(),
Types.DateType.get(),
+ Types.TimestampType.withZone(),
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
