lcspinter commented on a change in pull request #2126:
URL: https://github.com/apache/iceberg/pull/2126#discussion_r561151289
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -88,9 +91,10 @@
private static final List<Type> SUPPORTED_TYPES =
ImmutableList.of(Types.BooleanType.get(), Types.IntegerType.get(),
Types.LongType.get(),
- Types.FloatType.get(), Types.DoubleType.get(),
Types.DateType.get(), Types.TimestampType.withZone(),
+ Types.FloatType.get(), Types.DoubleType.get(),
Types.DateType.get(),
+ Types.TimestampType.withZone(),
Types.TimestampType.withoutZone(), Types.StringType.get(),
Types.BinaryType.get(),
- Types.DecimalType.of(3, 1), Types.UUIDType.get(),
Types.FixedType.ofLength(5),
+ Types.DecimalType.of(3, 1), Types.UUIDType.get(),
Types.FixedType.ofLength(11),
Review comment:
I would rather not add a new entry to this list. If we would like to
test the many flavours of the Decimal type, I guess we should do it in a
dedicated method/class.
##########
File path:
hive3/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergDateObjectInspectorHive3.java
##########
@@ -69,4 +69,8 @@ public Object copyObject(Object o) {
}
}
+ @Override
+ public LocalDate convert(Object o) {
+ return o == null ? null : LocalDate.of(((Date) o).getYear(), ((Date)
o).getMonth(), ((Date) o).getDay());
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
