C-Loftus commented on PR #2125: URL: https://github.com/apache/iceberg-go/pull/2125#issuecomment-6088933593
Thanks for your review @laskoviymishka ! Addressed both points: I added `TestWriteRejectsMismatchedGeoBatch` in table/internal/parquet_files_internal_test.go, which tests the write entry point (not the helper `accumulateGeoBounds` ) with three mismatched batches ( missing column, non-extension column, and incompatible extension storage) and asserts on the specific error from each. I verified it tests the regression by reverting the three guards to continue and rerunning: Write still returns an error either way (arrow-go's own schema-equality check in WriteBuffered independently rejects any batch whose declared schema doesn't match the writer's), so the test asserts on the specific error message rather than just error-presence, and it does fail when the guards are removed. Regarding your comment on the pseudo-version pin: still no tagged geoarrow-go release upstream, so there's nothing to bump to yet; I'll keep watching for a tag and switch once one exists, otherwise this stays as the documented, locked go.sum-pinned pseudo-version. Is that ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
