richiebachala opened a new pull request, #2172: URL: https://github.com/apache/iceberg-go/pull/2172
### What When `SupportsRenameTable` is `false` the catalog conformance suite now verifies that `RenameTable` returns `iceberg.ErrNotImplemented` instead of silently skipping the test. This catches a half-implemented or regressed rename that would otherwise stay green. Hadoop's `RenameTable` is updated to wrap its error with `iceberg.ErrNotImplemented` so the new assertion passes. ### Changes - **`catalog/catalogtest/tables.go`** — new `testRenameTableNotSupported` test that asserts `ErrNotImplemented` when the catalog does not support rename - **`catalog/catalogtest/catalogtest.go`** — register the new test; update `SupportsRenameTable` field doc to reference #1097 - **`catalog/hadoop/hadoop.go`** — wrap rename error with `iceberg.ErrNotImplemented` ### Dependencies This PR is stacked on #2165 (table lifecycle conformance tests). It should be merged after #2165. Fixes #2168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
