rdblue commented on a change in pull request #2022:
URL: https://github.com/apache/iceberg/pull/2022#discussion_r561425445
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteMergeInto.scala
##########
@@ -215,5 +227,41 @@ case class RewriteMergeInto(spark: SparkSession) extends
Rule[LogicalPlan] with
}
!(actions.size == 1 && hasUnconditionalDelete(actions.headOption))
}
+
+ def buildWritePlan(
+ childPlan: LogicalPlan,
+ table: Table): LogicalPlan = {
+ table match {
+ case iceTable: SparkTable =>
+ val numShufflePartitions = spark.sessionState.conf.numShufflePartitions
+ val table = iceTable.table()
+ val distributionMode: String = table.properties
+ .getOrDefault("write.distribution-mode",
TableProperties.WRITE_DISTRIBUTION_MODE_RANGE)
Review comment:
Isn't `write.distribution-mode` listed in `TableProperties`? We should
use the constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
