rdblue commented on a change in pull request #2022:
URL: https://github.com/apache/iceberg/pull/2022#discussion_r561461677
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteMergeInto.scala
##########
@@ -85,7 +96,7 @@ case class RewriteMergeInto(spark: SparkSession) extends
Rule[LogicalPlan] with
joinedAttributes = joinPlan.output
)
- val mergePlan = MergeInto(mergeParams, target, joinPlan)
+ val mergePlan = MergeInto(mergeParams, target.output, joinPlan)
Review comment:
Why not sort this case as well? If the user has requested a sort order
on the table, it makes sense to enforce it even if we aren't also rewriting
files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
