blackmwk opened a new pull request, #3104: URL: https://github.com/apache/iceberg-rust/pull/3104
## Which issue does this PR close? - Closes #3098. ## What changes are included in this PR? - Replace `HmsCatalogConfig` with crate-private `HmsCatalogProperties` derived through the shared `Properties` macro. - Store the catalog name and typed address, transport, and warehouse properties directly in `HmsCatalog`. - Preserve buffered fallback for unknown thrift transports and fail-fast validation for required address and warehouse properties. - Forward the complete raw property map to FileIO and KMS, matching the finalized Memory catalog pattern and Java-compatible behavior. - Add focused coverage for parsing, defaults, transport fallback, required-property validation, and downstream raw-property forwarding. ## Are these changes tested? - `cargo test -p iceberg-catalog-hms --lib` (21 passed) - `cargo clippy -p iceberg-catalog-hms --all-targets -- -D warnings` - `cargo public-api -p iceberg-catalog-hms --all-features -ss | diff - crates/catalog/hms/public-api.txt` - `cargo fmt --all -- --check` - `git diff --check` ## AI Disclosure This change was developed with assistance from OpenAI Codex. The contributor reviewed the resulting diff and test output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
