shangxinli commented on code in PR #1008:
URL: https://github.com/apache/iceberg-cpp/pull/1008#discussion_r4271880417
##########
src/iceberg/inspect/metadata_table.h:
##########
@@ -110,21 +140,36 @@ class ICEBERG_EXPORT TimeTravelMetadataTable : public
MetadataTable {
/// \brief Return true because this interface supports time travel.
bool supports_time_travel() const noexcept final;
- /// \brief Scan using the current snapshot on the main branch.
- Result<ArrowArrayStream> Scan() final;
+ // Scans without a snapshot selection read the current snapshot on the main
branch.
+ using MetadataTable::Scan;
Review Comment:
This pulls in Scan(const ColumnSelection&), which makes an existing call
like Scan({}) ambiguous against Scan(const SnapshotSelection&) since both are
aggregates. Is that source break intended, or would a distinct name for the
column-selection form avoid it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
