wgtmac commented on code in PR #1008:
URL: https://github.com/apache/iceberg-cpp/pull/1008#discussion_r4291326684
##########
src/iceberg/inspect/metadata_table.h:
##########
@@ -36,6 +38,20 @@
namespace iceberg {
+/// \brief Column selection for a metadata table scan.
+struct ColumnSelection {
+ /// \brief Names of the columns to return.
+ ///
+ /// Nested names are dot-concatenated. Columns are returned in schema order,
and
+ /// names that match no column are ignored. std::nullopt or a list
containing `*`
+ /// returns all columns. An empty list returns rows without columns.
Selecting a
+ /// map's value returns the whole map; selecting only its key is an error.
+ std::optional<std::vector<std::string>> names;
+
+ /// \brief Whether names are matched case-sensitively.
+ bool case_sensitive = true;
Review Comment:
Why not use a generic scan builder to pass them individually just like the
data table scan does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
