stevenzwu commented on code in PR #18394:
URL: https://github.com/apache/iceberg/pull/18394#discussion_r4273954879


##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -248,6 +254,30 @@ private CloseableIterable<TrackedFile> open() {
     return reader;
   }
 
+  private void registerGeospatialFieldStatsBounds(
+      InternalData.ReadBuilder readBuilder, Types.NestedField fieldStats) {
+    Types.NestedField tableField = 
tableSchema.findField(StatsUtil.toFieldId(fieldStats.fieldId()));

Review Comment:
   updated this to register `GeospatialBound` directly from the stats schema 
when a lower or upper bound is a struct. Added an inline comment to document 
the context. 
   
   I also renamed the methods to `registerCustomBoundTypes` and 
`registerStructBound`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to