PFischbeck commented on code in PR #18416:
URL: https://github.com/apache/iceberg/pull/18416#discussion_r4296443497
##########
format/spec.md:
##########
@@ -282,6 +283,7 @@ Supported primitive types are defined in the table below.
Primitive types added
| | **`uuid`** | Universally unique identifiers
| Should use 16-byte fixed
|
| | **`fixed(L)`** | Fixed-length byte array of length L
|
|
| | **`binary`** | Arbitrary-length byte array
|
|
+| [v4](#version-4) | **`vector(E, D)`** | Fixed-length collection of finite
numeric values with element type E and dimension D | E must be `int`, `long`,
`float`, or `double`; D must be positive |
Review Comment:
> The Parquet format discussion and I believe the community sync both
mentioned zero being an acceptable value.
Are you sure? The [current Parquet
proposal](https://github.com/apache/parquet-format/pull/624/changes#diff-0e877db0daf579f98a11e5e113b29250a2dcae3decb1e83a88db1e6f092bee96R1105-R1106)
mentions "greater than zero", and I'm not so sure about the benefit of a
zero-length vector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
