rdblue commented on a change in pull request #1981:
URL: https://github.com/apache/iceberg/pull/1981#discussion_r562304565
##########
File path: api/src/main/java/org/apache/iceberg/transforms/Dates.java
##########
@@ -99,11 +107,24 @@ public boolean satisfiesOrderOf(Transform<?, ?> other) {
if (pred.isUnaryPredicate()) {
return Expressions.predicate(pred.op(), fieldName);
+
} else if (pred.isLiteralPredicate()) {
- return ProjectionUtil.truncateInteger(fieldName,
pred.asLiteralPredicate(), this);
+ UnboundPredicate<Integer> projected =
ProjectionUtil.truncateInteger(fieldName, pred.asLiteralPredicate(), this);
+ if (this != DAY) {
Review comment:
There are only 4 instance of this, and they call 2 different fix
methods. I don't think it would be worth adding 2 methods just to dedup 4 lines
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
