Jecarm commented on a change in pull request #2119:
URL: https://github.com/apache/iceberg/pull/2119#discussion_r561483981
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -83,6 +83,20 @@ protected HiveMetaStoreClient reconnect(HiveMetaStoreClient
client) {
return client;
}
+ @Override
+ protected boolean failureDetection(HiveMetaStoreClient client, Exception ex)
{
Review comment:
Personally, I support this solution which is to detect the
MetaException that wraps TTransportException and return true.
If we can reach an agreement, I will do it in this way.
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -83,6 +83,20 @@ protected HiveMetaStoreClient reconnect(HiveMetaStoreClient
client) {
return client;
}
+ @Override
+ protected boolean failureDetection(HiveMetaStoreClient client, Exception ex)
{
Review comment:
The message of `TTransportException` wrapped by `MetaException` is as
follows:
```
ERROR - Got exception: org.apache.thrift.transport.TTransportException null
org.apache.thrift.transport.TTransportException: null at
org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:132)
~[libthrift-0.9.3.jar:0.9.3] at
org.apache.thrift.transport.TTransport.readAll(TTransport.java:86)
~[libthrift-0.9.3.jar:0.9.3] at
org.apache.thrift.protocol.TBinaryProtocol.readAll(TBinaryProtocol.java:429)
~[libthrift-0.9.3.jar:0.9.3] at
org.apache.thrift.protocol.TBinaryProtocol.readI32(TBinaryProtocol.java:318)
~[libthrift-0.9.3.jar:0.9.3] at
org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:219)
~[libthrift-0.9.3.jar:0.9.3] at
org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:77)
~[libthrift-0.9.3.jar:0.9.3] at
org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_get_all_tables(ThriftHiveMetastore.java:1487)
~[hive-metastore-2.3.7.jar:2.3.7] at
org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.get_all_tables(ThriftHiveMetastore.java:1474)
~[hive-metastore-2.3.7.jar:2.3.7] at
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.getAllTables(HiveMetaStoreClient.java:1451)
[hive-metastore-2.3.7.jar:2.3.7]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
