Jecarm commented on a change in pull request #2119:
URL: https://github.com/apache/iceberg/pull/2119#discussion_r563599761
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/ClientPool.java
##########
@@ -54,7 +54,7 @@
return action.run(client);
} catch (Exception exc) {
- if (reconnectExc.isInstance(exc)) {
+ if (reconnectExc.isInstance(exc) || failureDetection(exc)) {
Review comment:
Or just move reconnectExc.isInstance(exc) into the failureDetection(exc)
method in `ClientPool`, like this:
```
try {
return action.run(client);
} catch (Exception exc) {
if (failureDetection(exc)) {
...
}
}
protected boolean failureDetection(Exception exc) {
return reconnectExc.isInstance(exc);
}
```
@pvary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
