rdblue commented on a change in pull request #2134:
URL: https://github.com/apache/iceberg/pull/2134#discussion_r562801489
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteMergeInto.scala
##########
@@ -100,7 +101,7 @@ case class RewriteMergeInto(spark: SparkSession) extends
Rule[LogicalPlan] with
AppendData.byPosition(target, writePlan, Map.empty)
- case MergeIntoTable(target: DataSourceV2Relation, source: LogicalPlan,
cond, matchedActions, notMatchedActions)
+ case MergeIntoTable(target@ IcebergTable(_), source: LogicalPlan, cond,
matchedActions, notMatchedActions)
Review comment:
It would be a bit shorter and easier to understand if you used
`IcebergTable(target)` instead of `@`.
Can you also remove `: LogicalPlan`? Those aren't needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
