rdblue commented on a change in pull request #2134:
URL: https://github.com/apache/iceberg/pull/2134#discussion_r562804870
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/DeleteFromTablePredicateCheck.scala
##########
@@ -22,12 +22,13 @@ package org.apache.spark.sql.catalyst.analysis
import org.apache.spark.sql.AnalysisException
import org.apache.spark.sql.catalyst.expressions.{Expression, InSubquery, Not}
import org.apache.spark.sql.catalyst.plans.logical.{DeleteFromTable,
LogicalPlan}
+import org.apache.spark.sql.catalyst.utils.AliasedIcebergTable
object DeleteFromTablePredicateCheck extends (LogicalPlan => Unit) {
override def apply(plan: LogicalPlan): Unit = {
plan foreach {
- case DeleteFromTable(_, Some(condition)) if
hasNullAwarePredicateWithinNot(condition) =>
+ case DeleteFromTable(AliasedIcebergTable(_), Some(condition)) if
hasNullAwarePredicateWithinNot(condition) =>
Review comment:
Unlike my comment in the alignment rule, I think `DeleteFromTable` is a
more stable plan and unlikely to change, so it should be okay to embed the
matcher directly here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
