kumarpritam863 commented on code in PR #18582:
URL: https://github.com/apache/iceberg/pull/18582#discussion_r4325082257
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableUpdater.java:
##########
@@ -78,14 +78,28 @@ private void findOrCreateTable(
TableIdentifier identifier, Schema schema, PartitionSpec spec,
TableCreator tableCreator) {
Tuple2<Boolean, Exception> exists = cache.exists(identifier);
if (Boolean.FALSE.equals(exists.f0)) {
- if (exists.f1 instanceof NoSuchNamespaceException) {
+ // The lookup cannot tell a missing table from a missing namespace: the
Glue catalog, for
+ // instance, reports a table in a namespace that does not exist as
NoSuchTableException. Ask
+ // the catalog directly.
+ if (catalog instanceof SupportsNamespaces) {
Review Comment:
agreed, reworded. It now says that tasks arriving at the same time can all
find the namespace missing and try to create it (the AlreadyExistsException is
ignored), and that the catalog is asked instead of the lookup because catalogs
differ in which exception they throw (Glue throws NoSuchTableException) and a
cached answer carries none.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
