mbutrovich commented on PR #3388: URL: https://github.com/apache/iceberg-rust/pull/3388#issuecomment-6297018045
I found two more cases while rereading the reader against the spec. A v2 manifest can lack `file_sequence_number`, because the spec added the field in apache/iceberg#6002 after v2 manifests were already being written. The reader filled the missing column with 0, which the spec asks for only when [reading v1 manifests](https://github.com/apache/iceberg/blob/5e7169168db3d34e29354c6f59ec4d6e420b8d2d/format/spec.md?plain=1#L938). It now reads as null, so added entries inherit the manifest's sequence number as the [`manifest_entry` fields](https://github.com/apache/iceberg/blob/5e7169168db3d34e29354c6f59ec4d6e420b8d2d/format/spec.md?plain=1#L693) require. `test_v2_manifest_without_file_sequence_number_inherits` covers it. A negative `record_count` would assign overlapping first row IDs, so [first row ID inheritance](https://github.com/apache/iceberg/blob/5e7169168db3d34e29354c6f59ec4d6e420b8d2d/format/spec.md?plain=1#L944) now returns an error for it. `test_first_row_id_inheritance` covers it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
