rdblue commented on code in PR #18585: URL: https://github.com/apache/iceberg/pull/18585#discussion_r4328557164
########## format/spec.md: ########## @@ -1011,12 +1012,24 @@ For example, stats for an optional `geometry` field named `location` with field- 10_804: optional long value_count; 10_805: optional long null_value_count; 10_807: optional long total_bytes; - // tight_bounds and nan_value_count are omitted for geo types + // nan_value_count is omitted for geo types } ``` For `variant`, both bounds are unshredded `variant` that store variant field bounds by normalized JSON paths as field names. See [Bounds for Variant](#bounds-for-variant) for details on producing these bounds. +###### Stats Tightness + +Statistics are *tight* when the bounds, `null_value_count`, and `nan_value_count` are exact for the live rows of a file: + +* Bounds are the minimum and maximum of the live values. Bounds for `string` and `binary` are never tight because they may be truncated when written, and bounds for `geometry` and `geography` are a bounding box, not exact minimum and maximum values. Review Comment: > * Bounds for fixed-width types are the minimum and maximum for live values The second sentence should not be in the definition, it is a clarification that can come later. The idea is to be clear and direct and "fixed-width types" says what we need to. Leaving aside the specific cases makes this easier to understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
