kevinjqliu commented on code in PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#discussion_r4331419435
##########
.github/workflows/release_python.yml:
##########
@@ -125,6 +125,20 @@ jobs:
with:
version: ${{ steps.version.outputs.pep440 }}
+ - name: Install cargo-about
Review Comment:
the same changes for nightly release pipeline
##########
.github/workflows/release_python.yml:
##########
@@ -125,6 +125,20 @@ jobs:
with:
version: ${{ steps.version.outputs.pep440 }}
+ - name: Install cargo-about
+ uses: taiki-e/install-action@4cef1412cce204788f482e778a0b9187f9626a29
# v2.87.21
+ with:
+ tool: [email protected]
+
+ - name: Generate LICENSE with third-party licenses
+ shell: bash
+ run: |
+ # bindings/python/LICENSE is a placeholder: replace it with the root
LICENSE plus bundled dependency licenses.
+ {
+ cat LICENSE
Review Comment:
takes the original
[`LICENSE`](https://github.com/apache/iceberg-rust/blob/main/LICENSE) file from
repo root and append the `cargo about` output
##########
bindings/python/about.hbs:
##########
@@ -0,0 +1,63 @@
+{{!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+--}}
+
+--------------------------------------------------------------------------------
+
+This package bundles Rust dependencies. Their licenses follow.
+{{#each licenses}}
+
+--------------------------------------------------------------------------------
+
+{{{name}}}
+
+Used by:
+{{#each used_by}}
+ - {{crate.name}} {{crate.version}}{{#if crate.repository}}
({{crate.repository}}){{/if}}
+{{/each}}
+
+{{{text}}}
+{{/each}}
+
+--------------------------------------------------------------------------------
+
+MIT License
+
+Used by:
+ - brotli-decompressor 5.0.3
(https://github.com/dropbox/rust-brotli-decompressor)
Review Comment:
manual entry for `brotli`
##########
bindings/python/about.toml:
##########
@@ -0,0 +1,54 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Configuration for `cargo about`, which lists the license texts of the Rust
+# dependencies compiled into pyiceberg-core.
+#
+# Keep `accepted` in line with deny.toml.
+#
+# Accepted licenses must be ASF Category A or B:
+# https://www.apache.org/legal/resolved.html
+# Unicode-3.0 is not on that page; it is Category A per
+# https://issues.apache.org/jira/browse/LEGAL-660
+accepted = [
+ "Apache-2.0",
+ "BSD-3-Clause",
+ "CC0-1.0",
+ "ISC",
+ "MIT",
+ "Unicode-3.0",
+ "Zlib",
+]
+ignore-build-dependencies = true
+ignore-dev-dependencies = true
+
+# zstd-sys vendors zstd's C code (BSD-3-Clause, Meta) next to the Rust
Review Comment:
`zstd-sys` always compiles zstd's core C library ðŸ˜
but these changes dont look so bad
##########
bindings/python/LICENSE:
##########
Review Comment:
i put a `LICENSE` file here so that its searchable and explains how its
actually generated
##########
bindings/python/NOTICE:
##########
Review Comment:
manually added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
