dannycjones commented on code in PR #3493:
URL: https://github.com/apache/iceberg-rust/pull/3493#discussion_r4336491341
##########
bindings/python/about.hbs:
##########
@@ -0,0 +1,63 @@
+{{!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+--}}
+
+--------------------------------------------------------------------------------
+
+This package bundles Rust dependencies. Their licenses follow.
+{{#each licenses}}
+
+--------------------------------------------------------------------------------
+
+{{{name}}}
+
+Used by:
+{{#each used_by}}
+ - {{crate.name}} {{crate.version}}{{#if crate.repository}}
({{crate.repository}}){{/if}}
+{{/each}}
+
+{{{text}}}
+{{/each}}
+
+--------------------------------------------------------------------------------
+
+MIT License
+
+Used by:
+ - brotli-decompressor 5.0.3
(https://github.com/dropbox/rust-brotli-decompressor)
+ (src/context.rs)
+
+Copyright 2013 Google Inc. All Rights Reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of
+this software and associated documentation files (the "Software"), to deal in
+the Software without restriction, including without limitation the rights to
+use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
+of the Software, and to permit persons to whom the Software is furnished to do
+so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
Review Comment:
I'm OK with the tradeoff here to say we'll hardcode. I'm hoping that this
case is broadly the exception.
##########
bindings/python/LICENSE:
##########
Review Comment:
Agree with Renjie's comment here that this must stand on its own as a valid
license file for the source package.
https://github.com/apache/iceberg-rust/pull/3493#pullrequestreview-5598115587
##########
bindings/python/NOTICE:
##########
Review Comment:
It's weird that we're including notices here for dependencies, when we don't
distribute their source.
I'm not saying we can't do it, but maybe that we can stage this in another
file and copy it into place (perhaps a similar approach for `LICENSE` too)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
