pvary commented on PR #18508: URL: https://github.com/apache/iceberg/pull/18508#issuecomment-6317926534
Thanks! One note: IS NULL / NOT NULL only check eval(struct) == null, so the binary variants never read list or map elements. BinaryArrayData/BinaryMapData element reads are still only covered for Generic data. Also, please add a row where nested itself is null, to cover the null-parent path for nested.nested_tags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
