pvary commented on code in PR #18508:
URL: https://github.com/apache/iceberg/pull/18508#discussion_r4346612835
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/RowDataWrapper.java:
##########
@@ -37,28 +47,30 @@
public class RowDataWrapper implements StructLike {
Review Comment:
We could add some javadoc describing what can be used after a new wrap
```suggestion
/**
* Wraps Flink {@link RowData} as an Iceberg {@link StructLike}.
*
* <p>{@link #wrap(RowData)} reuses this instance, and nested structs, lists
and maps are views of
* the wrapped data rather than copies. They are only valid until the next
{@link #wrap(RowData)}
* call or until the {@link RowData} is reused, so copy them to keep them.
*/
public class RowDataWrapper implements StructLike {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
