Fokko commented on code in PR #4134:
URL: https://github.com/apache/iceberg-python/pull/4134#discussion_r4352071747
##########
tests/catalog/test_rest.py:
##########
@@ -3481,6 +3481,46 @@ def
test_load_table_catalog_config_outranks_table_properties(
assert table.io.properties["s3.proxy-uri"] == "http://table-only-proxy";
+def test_load_table_empty_catalog_signer_disables_remote_signing(
+ rest_mock: Mocker, example_table_metadata_with_snapshot_v1: dict[str, Any]
+) -> None:
+ metadata_location =
"s3://warehouse/database/table/metadata/00001.metadata.json"
+ rest_mock.get(
+ f"{TEST_URI}v1/namespaces/fokko/tables/table",
+ json={
+ "metadata-location": metadata_location,
+ "metadata": example_table_metadata_with_snapshot_v1,
+ "config": {"s3.signer": "S3V4RestSigner", "s3.signer.uri":
"http://signer"},
+ },
+ status_code=200,
+ request_headers=TEST_HEADERS,
+ )
+ catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN,
**{"s3.signer": ""})
+ table = catalog.load_table(("fokko", "table"))
Review Comment:
This seems akward to me. The catalog should pass valid information. @c-thiel
what is Lakekeeper doing here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
