Ankitraj-builds commented on code in PR #4134:
URL: https://github.com/apache/iceberg-python/pull/4134#discussion_r4353639398
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -645,6 +646,10 @@ def _load_file_io(
table_properties: Properties = EMPTY_DICT,
) -> FileIO:
merged_properties = {**table_properties, **self.properties,
**properties}
+ # An explicitly empty s3.signer in the catalog config opts out of
remote signing,
Review Comment:
Fair point. Would an explicit boolean like s3.remote-signing-enabled=false
be better? I can switch to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
