CTTY commented on code in PR #3474:
URL: https://github.com/apache/iceberg-rust/pull/3474#discussion_r4355482282
##########
crates/iceberg/src/spec/manifest/_serde.rs:
##########
@@ -100,8 +100,10 @@ impl ManifestEntryV1 {
Ok(ManifestEntry {
status: self.status.try_into()?,
snapshot_id: Some(self.snapshot_id),
- sequence_number: Some(0),
- file_sequence_number: Some(0),
+ // v1 entries carry no sequence numbers; they are inherited from
the
+ // manifest list entry on read, like a v2 entry with null fields.
+ sequence_number: None,
+ file_sequence_number: None,
Review Comment:
This is an existing bug, and I want to fix it here because it can save us
from validating `format_version` when getting manifests from the cache when
retrying in `SimpleSnapshotProducer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
