CTTY commented on code in PR #3474:
URL: https://github.com/apache/iceberg-rust/pull/3474#discussion_r4355593398
##########
crates/iceberg/src/spec/manifest/reader.rs:
##########
@@ -178,6 +178,35 @@ mod tests {
);
}
+ /// Per spec, inheritance does not apply to v1: a v1 manifest's entries
read
+ /// with sequence number 0 even when the manifest list entry referencing
them
+ /// carries a nonzero one.
+ #[tokio::test]
+ async fn test_read_v1_manifest_defaults_sequence_number_to_zero() {
Review Comment:
I was thinking about some cases that format version changes from V1 to V2
during retry attempts. Didn't find any issue, just think this test can be
helpful to clarify things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
