kevinjqliu commented on PR #4150: URL: https://github.com/apache/iceberg-python/pull/4150#issuecomment-6391262359
> Can we add something about using multiple tests if the parameters are sufficiently complicated? > > I've seen a number of tests that parameterize on 3-4+ very complicated fixtures. Even a for loop makes reading them a mess. The loss in readability doesn't make up for the few lines of code savings. yep I agree, seen similar. Added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
