kevinjqliu commented on code in PR #4151:
URL: https://github.com/apache/iceberg-python/pull/4151#discussion_r4369567610
##########
tests/integration/test_catalog.py:
##########
@@ -719,6 +719,53 @@ def test_rest_drop_view(
assert not rest_catalog.view_exists(identifier)
[email protected]
+def test_rest_identifiers_with_special_characters(
+ rest_catalog: RestCatalog, table_schema_simple: Schema,
example_view_metadata_v1: dict[str, Any]
+) -> None:
+ """Names that need URL encoding must round-trip unchanged through path,
query, and body parameters."""
+ # "%" is omitted because the REST fixture's Jetty rejects "%25" in URL
paths ("400 Ambiguous URI path encoding")
+ for name in ["with space", "a+b&c=d", "\u65e5\u672c"]:
+ parent = (f"{name}_{uuid.uuid4().hex}",)
+ namespace = (*parent, name)
+ table_identifier = (*namespace, f"table {name}")
+ view_identifier = (*namespace, f"view {name}")
+ registered_view_identifier = (*namespace, f"registered view {name}")
+
+ rest_catalog.create_namespace(parent)
+ rest_catalog.create_namespace(namespace, properties={"key": name})
+ assert parent in rest_catalog.list_namespaces()
+ assert rest_catalog.list_namespaces(parent) == [namespace]
+ assert rest_catalog.namespace_exists(namespace)
+ assert rest_catalog.load_namespace_properties(namespace)["key"] == name
+
+ rest_catalog.create_table(table_identifier, table_schema_simple)
+ assert rest_catalog.table_exists(table_identifier)
+ assert rest_catalog.list_tables(namespace) == [table_identifier]
+ table = rest_catalog.load_table(table_identifier)
+ assert table.name() == table_identifier
+ with table.transaction() as tx:
+ tx.set_properties(key=name)
+ assert rest_catalog.load_table(table_identifier).properties["key"] ==
name
+
+ view = View(view_identifier,
ViewMetadata.model_validate(example_view_metadata_v1))
+ created_view = rest_catalog.create_view(view_identifier,
view.schema(), view.current_version())
+ assert rest_catalog.view_exists(view_identifier)
+ assert rest_catalog.list_views(namespace) == [view_identifier]
+
+ assert created_view.metadata_location is not None
+ rest_catalog.register_view(registered_view_identifier,
created_view.metadata_location)
+ assert rest_catalog.view_exists(registered_view_identifier)
+ assert sorted(rest_catalog.list_views(namespace)) ==
sorted([view_identifier, registered_view_identifier])
Review Comment:
two views here because one is from `create_view`, another from
`register_review`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
