rambleraptor commented on code in PR #4151:
URL: https://github.com/apache/iceberg-python/pull/4151#discussion_r4369568813
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -1311,7 +1311,7 @@ def create_view(
location = location.rstrip("/")
request = CreateViewRequest(
- name=namespace_and_view["view"],
+ name=self._identifier_to_validated_tuple(identifier)[-1],
Review Comment:
Idea (not necessarily for this PR): what if Identifier still acted like a
tuple but had named methods on it as well? I really don't like the -1 here,
since it's not always intuitive why we're doing that.
Could you add a comment explaining what you're trying to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
