kevinjqliu opened a new pull request, #4154:
URL: https://github.com/apache/iceberg-python/pull/4154
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
`adls.anon` (added in #2661) is passed to adlfs as a raw string. adlfs
expects a bool ([`anon: bool =
None`](https://github.com/fsspec/adlfs/blob/2026.8.0/adlfs/spec.py#L310)) and
only falls back to `DefaultAzureCredential` when [`self.anon is
False`](https://github.com/fsspec/adlfs/blob/2026.8.0/adlfs/spec.py#L385-L391).
So `adls.anon=false` from string config silently skips default credentials and
requests go out anonymously.
Parse it with `property_as_bool`, leaving it `None` when unset so adlfs
still honours
[`AZURE_STORAGE_ANON`](https://github.com/fsspec/adlfs/blob/2026.8.0/adlfs/spec.py#L344-L348).
## Are these changes tested?
Yes. Added `test_adls_anon_parsed_as_bool`, which fails on `main` and passes
with this change.
`uv run python -m pytest tests/io/test_fsspec.py -k "anon_parsed or
adls_account_name or adls_does_not_mutate"`: 6 passed.
## Are there any user-facing changes?
`adls.anon="false"` now uses `DefaultAzureCredential` instead of anonymous
access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
