Copilot commented on code in PR #4154:
URL: https://github.com/apache/iceberg-python/pull/4154#discussion_r4369609271
##########
pyiceberg/io/fsspec.py:
##########
@@ -308,7 +308,7 @@ async def get_token(self, *scopes: str, **kwargs: Any) ->
AccessToken:
client_id=properties.get(ADLS_CLIENT_ID),
client_secret=properties.get(ADLS_CLIENT_SECRET),
account_host=properties.get(ADLS_ACCOUNT_HOST),
- anon=properties.get(ADLS_ANON),
+ anon=property_as_bool(properties, ADLS_ANON, False) if
properties.get(ADLS_ANON) else None,
Review Comment:
With `properties={"adls.anon": False}`, this truthiness guard now passes
`anon=None` instead of `False`. If `AZURE_STORAGE_ANON=true` is set, adlfs
consequently uses anonymous access rather than default credentials, breaking
the boolean configuration supported before this change. Check for an
unset/empty value instead of truthiness, and extend the regression test to
cover actual booleans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
