zhengxiang378928908-code commented on PR #18361: URL: https://github.com/apache/iceberg/pull/18361#issuecomment-6399615802
Thanks for the update. I re-ran my probe on `b9aa4ab9b`. All three cases from my earlier comment now pass on format versions 2–4: commit and scan planning succeed, with one planned task and one associated delete in each case (data and position delete/DV both built before the promotion; data built before with the delete built after; an equality delete built before, applied to data appended after). The same 14 core test classes as last time report 1,783 tests, 205 skipped, and zero failures or errors. One request: the new commit changes only `ManifestWriter`, so the delete-file path still has no test in this PR. Could you add the position-delete/DV and equality-delete cases to the test suite, e.g. next to the existing `TestMergeAppend` cases using `newRowDelta()`? For the equality-delete case, please also run scan planning, because a missing `equalityFieldIds` only fails there. I'm happy to share my probe test as a starting point. These are still metadata-only probes through the core API; they don't read actual data or delete-file contents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
